refactor: use internalAccount instead of account address for granular updates
#4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-notifications
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
previously approved these changes
Sep 12, 2024
| @@ -1104,7 +1104,7 @@ describe('user-storage/user-storage-controller - saveInternalAccountToUserStorag | |||
| }); | |||
|
|
|||
| await controller.saveInternalAccountToUserStorage( | |||
| MOCK_INTERNAL_ACCOUNTS.ONE[0].address, | |||
| MOCK_INTERNAL_ACCOUNTS.ONE[0] as InternalAccount, | |||
There was a problem hiding this comment.
Just want to make sure, is this assertion valid? If so then all good!
There was a problem hiding this comment.
Yes definitely! It's just that my data doesn't 100% intersect with type InternalAccount since it misses some keys we don't really care about, and I didn't want to bloat up the fixtures.
|
@metamaskbot publish-preview |
Prithpal-Sooriya
approved these changes
Sep 12, 2024
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the parameter for
UserStorageControllersaveInternalAccountToUserStoragefrom an account address to anInternalAccount.This helps because we're listening to
AccountsControllerevents and they are passing anInternalAccountas their return value. By using this return value directly, we remove some unnecessary logic & queries.Explanation
References
Changelog
@metamask/profile-sync-controllerInternalAccountinstead of account address forsaveInternalAccountToUserStorageparameterChecklist