Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paralellization of add detected tokens instead of sequencial #4697

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Sep 13, 2024

Explanation

We were doing this sequentially on batches of 1000 tokens to detect if tokens have balance. This solution suggests that we do this parallelized.

References

Changelog

@metamask/assets-controllers

  • : Paralelization of detected tokens with balance
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini tommasini marked this pull request as ready for review September 13, 2024 12:24
@tommasini tommasini requested a review from a team as a code owner September 13, 2024 12:24
@blurpesec
Copy link
Contributor

blurpesec commented Sep 13, 2024

@tommasini - Have you tested this locally ? On Ethereum - the process of parallelizing the RPC requests may be throttled by the compute necessary to establish new connections depending on the number of parallel connections needed and the prior free connection count.

@tommasini
Copy link
Contributor Author

Thanks for having the time @blurpesec ! I didn't had the opportunity to check this locally yet! Will get back with more information here!

@tommasini tommasini merged commit 8a37db1 into main Sep 17, 2024
116 checks passed
@tommasini tommasini deleted the chore/parallelization-add-detected-tokens branch September 17, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants