refactor: profile-sync-sdk move snap methods to snap auth class #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
| } | ||
| const res = await connectSnap(provider); | ||
| return res; | ||
| this.#assertSRP(this.#type, this.#sdk); |
There was a problem hiding this comment.
Ensures that we keep some separation of concerns between SIWE Auth and SRP Auth classes.
We do not want SIWE AuthType from calling these snap methods.
packages/profile-sync-controller/src/sdk/utils/messaging-signing-snap-requests.ts
Show resolved
Hide resolved
…k/core into notify/clean-up-sdk-connect-snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This is so we can keep some separation of concerns and prevent SIWE auth SDK from using these public snap methods.
References
Changelog
@metamask/profile-sync-controllerassertSRPprivate method to ensure that only SRP auth can call the snap methods.isSnapConnectedandconnectSnapto the Snap Auth SDK.getSnapexported methodChecklist