chore: update 'eth-{simple,hd,snap}-keyring' + 'keyring-api' #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
56326ab
to
067f2f0
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
067f2f0
to
bff78ca
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
2 times, most recently
from
1bea6e0
to
40bcceb
Compare
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
40bcceb
to
4968a25
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Preview builds have been tested against the extension on
Some snapshots had to be updated too, which seems to be related to: |
ccharly
force-pushed
the
feature/use-new-accounts-packages
branch
from
d09e6f9
to
2e2cf11
Compare
danroc
approved these changes
Sep 24, 2024
danroc
changed the title
matthewwalsh0
approved these changes
Sep 24, 2024
digiwand
approved these changes
Sep 24, 2024
7 tasks
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 7, 2024
## **Description** Updating packages to use versions coming from the new [accounts monorepo](https://github.com/MetaMask/accounts). [](https://codespaces.new/MetaMask/metamask-extension/pull/27284?quickstart=1) ## **Related issues** Related to: - MetaMask/accounts#39 - MetaMask/accounts#50 - MetaMask/accounts#54 - MetaMask/core#4713 - MetaMask/core#4734 - MetaMask/snap-simple-keyring#156 - MetaMask/snap-watch-only#52 - MetaMask/snap-bitcoin-wallet#255 - MetaMask/snap-account-abstraction-keyring#142 ## **Manual testing steps** Test parts of the extension that closely related to accounts management + HW wallets support. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27284?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Those new versions have been created using the new
accountsmonorepo.We are updating them to make sure this new way of building those packages has no unintended side-effects.
References
Related to:
Changelog
@metamask/keyring-controller@metamask/eth-hd-keyringto ^7.0.3@metamask/eth-simple-keyringto ^6.0.4@metamask/keyring-apito ^8.1.2@metamask/accounts-controller@metamask/eth-snap-keyringto ^4.3.5@metamask/keyring-apito ^8.1.2@metamask/assets-controller@metamask/keyring-apito ^8.1.2@metamask/chain-controller@metamask/keyring-apito ^8.1.2@metamask/transaction-controller@metamask/keyring-apito ^8.1.2@metamask/profile-sync-controller@metamask/keyring-apito ^8.1.2Checklist