Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for bridge txs #4714

Merged
merged 7 commits into from
Oct 3, 2024
Merged

feat: add types for bridge txs #4714

merged 7 commits into from
Oct 3, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Sep 18, 2024

Explanation

This PR adds additional types to facilitate Bridge development in Extension.

References

Related to: MetaMask/metamask-extension#27262

Changelog

@metamask/transaction-controller

  • ADDED: bridgeApproval, bridge types

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@infiniteflower infiniteflower marked this pull request as ready for review September 26, 2024 14:49
@infiniteflower infiniteflower requested review from a team as code owners September 26, 2024 14:49
packages/transaction-controller/src/types.ts Outdated Show resolved Hide resolved
packages/transaction-controller/src/types.ts Outdated Show resolved Hide resolved
@infiniteflower infiniteflower merged commit ffb0ca6 into main Oct 3, 2024
116 checks passed
@infiniteflower infiniteflower deleted the feat/bridge-tx-type branch October 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants