refactor: move and organize shared profile sync dependencies #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
mathieuartu
approved these changes
Sep 19, 2024
Prithpal-Sooriya
deleted the
NOTIFY-1129/decouple-profile-sync-sdk-and-controller-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This decouples dependencies between profile sync SDK and profile sync Controllers.
It creates a shared section that both can use instead of the "cyclic dependencies". This should also help with tree shaking and reducing bundle size if using a subpath export.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1129
Changelog
@metamask/profile-sync-controllerencryptionfolder into shared folderstorage-schemainto shared folderenvinto shared folderencryptionfile in SDK to instead use shared encryption file.Checklist