improv: account syncing performance #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
1 similar comment
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
approved these changes
Sep 25, 2024
| await this.messagingSystem.call('KeyringController:addNewAccount'); | ||
| await waitForExpectedValue( |
| if (!this.#accounts.canSync()) { | ||
| if ( | ||
| !this.#accounts.canSync() || | ||
| !isEvmAccountType(internalAccount.type) || |
There was a problem hiding this comment.
This is okay. I find that once we have more than 1 boolean operand (&&/||) it gets a little confusing. Maybe could split out into a separate func?
| * @returns A promise that resolves when the expected value is returned | ||
| * or rejects if the timeout is reached. | ||
| */ | ||
| export function waitForExpectedValue<TVariable>( |
There was a problem hiding this comment.
Since we had to resort to this, really nice util.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds multiple improvements for the account syncing process, namely:
AccountsController:accountAddedevent to fire before adding another accountReferences
NOTIFY-1158
Changelog
@metamask/profile-sync-controllerisEvmAccountTypebefore saving an account in user storage in account syncingKeyringTypebefore saving an account in user storage in account syncingAccountsController:accountAddedevent to fire before adding another account in account syncingChecklist