Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove gasPrice property from linea_estimateGas request #4737

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 26, 2024

Explanation

The LineaGasFeeFlow in the TransactionController aims to provide more accurate gas fee estimates derived from a specific transaction, rather than just at the network level.

This is achieved via a request to the custom linea_estimateGas RPC method on the provider.

Originally, the gasPrice property was necessary to prevent a bug, but now that issue has been fixed remotely, it is itself causing an alternate bug that returns the following error mesage:

transaction up-front cost 0x16e360000000000 exceeds transaction sender account balance 0x7b2c1918e11642

This PR simply removes the gasPrice property from the request.

References

Changelog

### Fixed

- Remove `gasPrice` from requests to `linea_estimateGas` ([#4737](https://github.com/MetaMask/core/pull/4737))

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-1510ded6",
  "@metamask-previews/address-book-controller": "6.0.1-preview-1510ded6",
  "@metamask-previews/announcement-controller": "7.0.1-preview-1510ded6",
  "@metamask-previews/approval-controller": "7.1.0-preview-1510ded6",
  "@metamask-previews/assets-controllers": "38.1.0-preview-1510ded6",
  "@metamask-previews/base-controller": "7.0.1-preview-1510ded6",
  "@metamask-previews/build-utils": "3.0.1-preview-1510ded6",
  "@metamask-previews/chain-controller": "0.1.3-preview-1510ded6",
  "@metamask-previews/composable-controller": "9.0.1-preview-1510ded6",
  "@metamask-previews/controller-utils": "11.3.0-preview-1510ded6",
  "@metamask-previews/ens-controller": "14.0.1-preview-1510ded6",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-1510ded6",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-1510ded6",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-1510ded6",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-1510ded6",
  "@metamask-previews/keyring-controller": "17.2.2-preview-1510ded6",
  "@metamask-previews/logging-controller": "6.0.1-preview-1510ded6",
  "@metamask-previews/message-manager": "10.1.1-preview-1510ded6",
  "@metamask-previews/name-controller": "8.0.1-preview-1510ded6",
  "@metamask-previews/network-controller": "21.0.1-preview-1510ded6",
  "@metamask-previews/notification-controller": "7.0.0-preview-1510ded6",
  "@metamask-previews/notification-services-controller": "0.8.1-preview-1510ded6",
  "@metamask-previews/permission-controller": "11.0.2-preview-1510ded6",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-1510ded6",
  "@metamask-previews/phishing-controller": "12.0.3-preview-1510ded6",
  "@metamask-previews/polling-controller": "10.0.1-preview-1510ded6",
  "@metamask-previews/preferences-controller": "13.0.3-preview-1510ded6",
  "@metamask-previews/profile-sync-controller": "0.9.3-preview-1510ded6",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-1510ded6",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-1510ded6",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-1510ded6",
  "@metamask-previews/signature-controller": "19.1.0-preview-1510ded6",
  "@metamask-previews/transaction-controller": "37.1.0-preview-1510ded6",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-1510ded6"
}

@matthewwalsh0 matthewwalsh0 merged commit 66c94ae into main Sep 26, 2024
116 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/remove-linea-estimate-gas-price branch September 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants