-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reset notifications flow #4738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
label
Sep 26, 2024
...ion-services-controller/src/NotificationServicesController/NotificationServicesController.ts
Show resolved
Hide resolved
@metamaskbot publish-preview |
Jonathansoufer
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cool, will merge once we have a preview build to test on mobile :) |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-notifications
Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds the ability for users or developers to reset their remote notification state. For example recovering from a corrupted state, or to just clear existing notifications.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1168
Changelog
@metamask/notification-services-controller
resetNotifications
option during the notification creation flowChecklist