Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reset notifications flow #4738

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

Explanation

This adds the ability for users or developers to reset their remote notification state. For example recovering from a corrupted state, or to just clear existing notifications.

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1168

Changelog

@metamask/notification-services-controller

  • ADDED: resetNotifications option during the notification creation flow

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner September 26, 2024 10:51
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 26, 2024
@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya
Copy link
Contributor Author

Cool, will merge once we have a preview build to test on mobile :)

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-f576f94",
  "@metamask-previews/address-book-controller": "6.0.1-preview-f576f94",
  "@metamask-previews/announcement-controller": "7.0.1-preview-f576f94",
  "@metamask-previews/approval-controller": "7.1.0-preview-f576f94",
  "@metamask-previews/assets-controllers": "38.1.0-preview-f576f94",
  "@metamask-previews/base-controller": "7.0.1-preview-f576f94",
  "@metamask-previews/build-utils": "3.0.1-preview-f576f94",
  "@metamask-previews/chain-controller": "0.1.3-preview-f576f94",
  "@metamask-previews/composable-controller": "9.0.1-preview-f576f94",
  "@metamask-previews/controller-utils": "11.3.0-preview-f576f94",
  "@metamask-previews/ens-controller": "14.0.1-preview-f576f94",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-f576f94",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-f576f94",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-f576f94",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-f576f94",
  "@metamask-previews/keyring-controller": "17.2.2-preview-f576f94",
  "@metamask-previews/logging-controller": "6.0.1-preview-f576f94",
  "@metamask-previews/message-manager": "10.1.1-preview-f576f94",
  "@metamask-previews/name-controller": "8.0.1-preview-f576f94",
  "@metamask-previews/network-controller": "21.0.1-preview-f576f94",
  "@metamask-previews/notification-controller": "7.0.0-preview-f576f94",
  "@metamask-previews/notification-services-controller": "0.8.1-preview-f576f94",
  "@metamask-previews/permission-controller": "11.0.2-preview-f576f94",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-f576f94",
  "@metamask-previews/phishing-controller": "12.0.3-preview-f576f94",
  "@metamask-previews/polling-controller": "10.0.1-preview-f576f94",
  "@metamask-previews/preferences-controller": "13.0.3-preview-f576f94",
  "@metamask-previews/profile-sync-controller": "0.9.3-preview-f576f94",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-f576f94",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-f576f94",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-f576f94",
  "@metamask-previews/signature-controller": "19.1.0-preview-f576f94",
  "@metamask-previews/transaction-controller": "37.1.0-preview-f576f94",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-f576f94"
}

@Prithpal-Sooriya Prithpal-Sooriya merged commit b6a11a4 into main Sep 27, 2024
116 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the NOTIFY-1168/add-reset-notifications branch September 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants