fix: change gas limit fallback #4739
Open
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
requested changes
Sep 26, 2024
| @@ -60,7 +60,7 @@ export async function estimateGas( | |||
| const gasLimitBN = hexToBN(gasLimitHex); | |||
|
|
|||
| request.data = data ? add0x(data) : data; | |||
| request.gas = BNToHex(fractionBN(gasLimitBN, 19, 20)); | |||
There was a problem hiding this comment.
Should we take the time to define both of these as standard constants?
| @@ -96,7 +96,7 @@ export function addGasBuffer( | |||
| multiplier: number, | |||
| ) { | |||
| const estimatedGasBN = hexToBN(estimatedGas); | |||
| const maxGasBN = hexToBN(blockGasLimit).muln(0.9); | |||
| const maxGasBN = hexToBN(blockGasLimit).muln(0.3); | |||
There was a problem hiding this comment.
Was this also confirmed as a safe value?
There was a problem hiding this comment.
This was not an intended change, removed it.
OGPoyraz
force-pushed
the
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
branch
from
605eb03
to
1e6be12
Compare
…5-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations.
References
Fixes: MetaMask/metamask-extension#19692
Changelog
@metamask/transaction-controllerChecklist