Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NOTIFY-1171): fix account syncing performance #4746

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix(NOTIFY-1171): fix account syncing performance #4746

merged 3 commits into from
Oct 1, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 30, 2024 •
edited
Loading

Explanation

This PR solves various performance issues with user storage encryption / decryption + account syncing specific bugs. More info in the changelog.

References

Changelog

@metamask/profile-sync-controller

  • CHANGED: batch GET / PUT now encrypts and decrypts sequentially in order to leverage cache
  • FIXED: don't save nameLastUpdatedAt to user storage if account name is a default name
  • REMOVED: remove randomBytes from the encryption mechanism
  • REMOVED: remove waitForExpectedValue and stop waiting for AccountsController:accountAdded callback

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 30, 2024
@mathieuartu mathieuartu marked this pull request as ready for review September 30, 2024 18:30
@mathieuartu mathieuartu requested a review from a team as a code owner September 30, 2024 18:30
@mathieuartu mathieuartu merged commit 991cace into main Oct 1, 2024
116 checks passed
@mathieuartu mathieuartu deleted the fix/various_account_sync_fixes branch October 1, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobeat legobeat legobeat left review comments

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieuartu @Prithpal-Sooriya @legobeat