Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp: profile sync encryption perf analysis #4751

Closed
wants to merge 4 commits into from
Closed

temp: profile sync encryption perf analysis #4751

wants to merge 4 commits into from

Conversation

Prithpal-Sooriya
Copy link
Contributor

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-13318eb",
  "@metamask-previews/address-book-controller": "6.0.1-preview-13318eb",
  "@metamask-previews/announcement-controller": "7.0.1-preview-13318eb",
  "@metamask-previews/approval-controller": "7.1.0-preview-13318eb",
  "@metamask-previews/assets-controllers": "38.1.0-preview-13318eb",
  "@metamask-previews/base-controller": "7.0.1-preview-13318eb",
  "@metamask-previews/build-utils": "3.0.1-preview-13318eb",
  "@metamask-previews/chain-controller": "0.1.3-preview-13318eb",
  "@metamask-previews/composable-controller": "9.0.1-preview-13318eb",
  "@metamask-previews/controller-utils": "11.3.0-preview-13318eb",
  "@metamask-previews/ens-controller": "14.0.1-preview-13318eb",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-13318eb",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-13318eb",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-13318eb",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-13318eb",
  "@metamask-previews/keyring-controller": "17.2.2-preview-13318eb",
  "@metamask-previews/logging-controller": "6.0.1-preview-13318eb",
  "@metamask-previews/message-manager": "10.1.1-preview-13318eb",
  "@metamask-previews/name-controller": "8.0.1-preview-13318eb",
  "@metamask-previews/network-controller": "21.0.1-preview-13318eb",
  "@metamask-previews/notification-controller": "7.0.0-preview-13318eb",
  "@metamask-previews/notification-services-controller": "0.8.2-preview-13318eb",
  "@metamask-previews/permission-controller": "11.0.2-preview-13318eb",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-13318eb",
  "@metamask-previews/phishing-controller": "12.0.3-preview-13318eb",
  "@metamask-previews/polling-controller": "10.0.1-preview-13318eb",
  "@metamask-previews/preferences-controller": "13.0.3-preview-13318eb",
  "@metamask-previews/profile-sync-controller": "0.9.4-preview-13318eb",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-13318eb",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-13318eb",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-13318eb",
  "@metamask-previews/signature-controller": "19.1.0-preview-13318eb",
  "@metamask-previews/transaction-controller": "37.1.0-preview-13318eb",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-13318eb"
}

@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-2b91ea1",
  "@metamask-previews/address-book-controller": "6.0.1-preview-2b91ea1",
  "@metamask-previews/announcement-controller": "7.0.1-preview-2b91ea1",
  "@metamask-previews/approval-controller": "7.1.0-preview-2b91ea1",
  "@metamask-previews/assets-controllers": "38.1.0-preview-2b91ea1",
  "@metamask-previews/base-controller": "7.0.1-preview-2b91ea1",
  "@metamask-previews/build-utils": "3.0.1-preview-2b91ea1",
  "@metamask-previews/chain-controller": "0.1.3-preview-2b91ea1",
  "@metamask-previews/composable-controller": "9.0.1-preview-2b91ea1",
  "@metamask-previews/controller-utils": "11.3.0-preview-2b91ea1",
  "@metamask-previews/ens-controller": "14.0.1-preview-2b91ea1",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-2b91ea1",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-2b91ea1",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-2b91ea1",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-2b91ea1",
  "@metamask-previews/keyring-controller": "17.2.2-preview-2b91ea1",
  "@metamask-previews/logging-controller": "6.0.1-preview-2b91ea1",
  "@metamask-previews/message-manager": "10.1.1-preview-2b91ea1",
  "@metamask-previews/name-controller": "8.0.1-preview-2b91ea1",
  "@metamask-previews/network-controller": "21.0.1-preview-2b91ea1",
  "@metamask-previews/notification-controller": "7.0.0-preview-2b91ea1",
  "@metamask-previews/notification-services-controller": "0.8.2-preview-2b91ea1",
  "@metamask-previews/permission-controller": "11.0.2-preview-2b91ea1",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-2b91ea1",
  "@metamask-previews/phishing-controller": "12.0.3-preview-2b91ea1",
  "@metamask-previews/polling-controller": "10.0.1-preview-2b91ea1",
  "@metamask-previews/preferences-controller": "13.0.3-preview-2b91ea1",
  "@metamask-previews/profile-sync-controller": "0.9.4-preview-2b91ea1",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-2b91ea1",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-2b91ea1",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-2b91ea1",
  "@metamask-previews/signature-controller": "19.1.0-preview-2b91ea1",
  "@metamask-previews/transaction-controller": "37.1.0-preview-2b91ea1",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-2b91ea1"
}

@Prithpal-Sooriya Prithpal-Sooriya changed the title add test perf methods temp: profile sync encryption perf analysis Oct 1, 2024
@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-a796ac7",
  "@metamask-previews/address-book-controller": "6.0.1-preview-a796ac7",
  "@metamask-previews/announcement-controller": "7.0.1-preview-a796ac7",
  "@metamask-previews/approval-controller": "7.1.0-preview-a796ac7",
  "@metamask-previews/assets-controllers": "38.1.0-preview-a796ac7",
  "@metamask-previews/base-controller": "7.0.1-preview-a796ac7",
  "@metamask-previews/build-utils": "3.0.1-preview-a796ac7",
  "@metamask-previews/chain-controller": "0.1.3-preview-a796ac7",
  "@metamask-previews/composable-controller": "9.0.1-preview-a796ac7",
  "@metamask-previews/controller-utils": "11.3.0-preview-a796ac7",
  "@metamask-previews/ens-controller": "14.0.1-preview-a796ac7",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-a796ac7",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-a796ac7",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-a796ac7",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-a796ac7",
  "@metamask-previews/keyring-controller": "17.2.2-preview-a796ac7",
  "@metamask-previews/logging-controller": "6.0.1-preview-a796ac7",
  "@metamask-previews/message-manager": "10.1.1-preview-a796ac7",
  "@metamask-previews/name-controller": "8.0.1-preview-a796ac7",
  "@metamask-previews/network-controller": "21.0.1-preview-a796ac7",
  "@metamask-previews/notification-controller": "7.0.0-preview-a796ac7",
  "@metamask-previews/notification-services-controller": "0.8.2-preview-a796ac7",
  "@metamask-previews/permission-controller": "11.0.2-preview-a796ac7",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-a796ac7",
  "@metamask-previews/phishing-controller": "12.0.3-preview-a796ac7",
  "@metamask-previews/polling-controller": "10.0.1-preview-a796ac7",
  "@metamask-previews/preferences-controller": "13.0.3-preview-a796ac7",
  "@metamask-previews/profile-sync-controller": "0.9.4-preview-a796ac7",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-a796ac7",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-a796ac7",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-a796ac7",
  "@metamask-previews/signature-controller": "19.1.0-preview-a796ac7",
  "@metamask-previews/transaction-controller": "37.1.0-preview-a796ac7",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-a796ac7"
}

Prithpal-Sooriya
Prithpal-Sooriya commented Oct 2, 2024
View reviewed changes
packages/assets-controllers/src/TokenDetectionController.ts
@@ -169,6 +169,7 @@ export class TokenDetectionController extends StaticIntervalPollingController<

#isDetectionEnabledForNetwork: boolean;

// OOOH interesting, this is from another controller!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL ignore these, these are from another PR I'm working on.

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Oct 16, 2024
@Prithpal-Sooriya
Copy link
Contributor Author

Closing as we have done perf analysis on this repo and extension.
We can re-open this PR to test mobile in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Prithpal-Sooriya