feat: add more bridge fields to txMeta for Bridge #4918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds
sourceChainId
anddestinationChainId
to theTransactionMeta
type.This is needed for Bridge transactions. We track overall Bridge status through a new
BridgeStatusController
in Extension. However, that assumes that transactions have atxHash
on the source chain that can be used as a reference. For smart transactions, atxHash
is not returned immediately. Therefore, we need to attach some additional data to thetxMeta
so we can properly display information about the transaction even when there is notxHash
.References
Related to MetaMask/metamask-extension#27740
Changelog
@metamask/transaction-controller
bridgeSteps
,destinationChainId
to theTransactionMeta
typeaddTransaction()
, update thetxMeta
object through theswaps.meta
field when it is a Bridge tx, similar to what happens when it's a Swap txTransactionControllerTransactionNewBridgeApprovalEvent
,TransactionControllerTransactionNewBridgeEvent
eventsChecklist