Performance updates #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 1081 1086 +5
Branches 123 125 +2
=====================================
+ Hits 1081 1086 +5
Continue to review full report at Codecov.
|
bitpshr
approved these changes
Mar 11, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 11.0.2 to 11.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.0.2...v11.1.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kanthesha
pushed a commit
that referenced
this pull request
Sep 25, 2023
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* some performance updates * fix asset detection when no selectedAddress * increase polling interval to 12s * set default network to mainnet * set node version to 8
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* some performance updates * fix asset detection when no selectedAddress * increase polling interval to 12s * set default network to mainnet * set node version to 8
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent some time on the app side trying to identify the bottlenecks and this is the stuff I found:
Change network controller polling from 8 to 12 seconds (Based on https://etherscan.io/chart/blocktime blocktime was never below 13) so by changing this we're doing 30% less requests.
Update account balance in state right after each individual request. The state wasn't updating immediately causing a noticeable delay in the UI.
Make "mainnet" the default network. This is how every client is supposed to initialize by default so we're avoiding extra requests to another network on startup.
Prevent asset detection (tokens & collectibles) if the selectedAddress wasn't set.
providerandselectedAddressare two independent config settings and we should only try to detect assets once we have both.Don't verify network on new block - I couldn't find a good answer about why we should be calling infura with net_version right after getting a new block. This was doubling the amount of requests to infura on our end.
Unrelated: GABA is using the latest version of node for travisCI and jest broke in node 11.11.0, so I had to downgrade. Since we're using the latest stable version of node 8 in the app and extension, I've set it up like that here too.