Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use checksum addresses for comparison in ignoreLists #88

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Apr 4, 2019

Forgot to convert with toChecksumAddress before comparing against the already ignored assets

@brunobar79 brunobar79 changed the title use checksum addresses for comparison use checksum addresses for comparison in ignoreLists Apr 4, 2019
@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #88   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1356   1357    +1     
  Branches      174    174           
=====================================
+ Hits         1356   1357    +1
Impacted Files Coverage Δ
src/AssetsDetectionController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d4b2f...c3ec04a. Read the comment docs.

@brunobar79 brunobar79 merged commit cd13554 into master Apr 4, 2019
@whymarrh whymarrh deleted the fix-ignore-list-comparison branch November 5, 2019 17:43
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
Bump peaceiris/actions-gh-pages to more recent version
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.7 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.7...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Stacey <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants