Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 #146

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 #146

merged 1 commit into from
Jul 26, 2024

Conversation

legobeat
Copy link
Contributor

No description provided.

@socket-security Socket Security
Copy link

socket-security bot commented May 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] None 0 20.1 kB lmbot
npm/@lavamoat/[email protected] environment 0 46.8 kB lmbot
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@npmcli/[email protected] environment, filesystem 0 23 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 39.5 kB npm-cli-ops
npm/@npmcli/[email protected] environment, shell 0 12.2 kB npm-cli-ops
npm/@npmcli/[email protected] environment 0 18.4 kB npm-cli-ops
npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] network 0 31.2 kB tootallnate
npm/[email protected] filesystem 0 20.7 kB npm-cli-ops
npm/[email protected] filesystem 0 63.7 kB npm-cli-ops
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] filesystem 0 14.4 kB npm-cli-ops
npm/[email protected] None 0 26.6 kB npm-cli-ops
npm/[email protected] network 0 23.3 kB tootallnate
npm/[email protected] network 0 34.9 kB tootallnate
npm/[email protected] None 0 12.1 kB npm-cli-ops
npm/[email protected] None 0 177 kB beaugunderson
npm/[email protected] None 0 46.9 kB andyperlitch
npm/[email protected] None 0 15.7 kB isaacs
npm/[email protected] network 0 52.8 kB npm-cli-ops
npm/[email protected] None 0 4.96 kB isaacs
npm/[email protected] environment, network 0 46.8 kB npm-cli-ops
npm/[email protected] None 0 286 kB isaacs
npm/[email protected] environment, shell 0 1.85 MB nodejs-foundation
npm/[email protected] None 0 26.2 kB npm-cli-ops
npm/[email protected] None 0 28.2 kB npm-cli-ops
npm/[email protected] None 0 6.21 kB npm-cli-ops
npm/[email protected] None 0 3.58 kB npm-cli-ops
npm/[email protected] None 0 19.2 kB npm-cli-ops
npm/[email protected] None 0 16.5 kB npm-cli-ops
npm/[email protected] None 0 12.3 kB npm-cli-ops
npm/[email protected] None 0 95.8 kB npm-cli-ops
npm/[email protected] network 0 24.8 kB tootallnate
npm/[email protected] network 0 156 kB joshglazebrook
npm/[email protected] None 0 23.4 kB kemitchell
npm/[email protected] None 0 39.9 kB alexei
npm/[email protected] None 0 38.7 kB npm-cli-ops
npm/[email protected] None 0 3.41 kB lukekarrys
npm/[email protected] None 0 2.58 kB lukekarrys
npm/[email protected] None 0 16.6 kB kemitchell
npm/[email protected] unsafe 0 7.77 kB npm-cli-ops
npm/[email protected] None 0 14.8 kB isaacs

🚮 Removed packages: npm/@gar/[email protected], npm/@lavamoat/[email protected], npm/@lavamoat/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@tootallnate/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 21, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/@npmcli/[email protected] 🚫
Network access npm/@npmcli/[email protected] 🚫
Network access npm/@npmcli/[email protected] 🚫
Network access npm/@npmcli/[email protected] 🚫
Network access npm/@npmcli/[email protected] 🚫
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
Unstable ownership npm/@lavamoat/[email protected] 🚫
New author npm/@lavamoat/[email protected] 🚫
New author npm/@lavamoat/[email protected] 🚫
Unstable ownership npm/@lavamoat/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat marked this pull request as ready for review May 21, 2024 04:47
@legobeat legobeat requested a review from a team as a code owner May 21, 2024 04:47
@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 21, 2024
mcmire
mcmire previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing, this LGTM.

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 63163b6 to 6385152 Compare July 26, 2024 20:35
@legobeat
Copy link
Contributor Author

Sorry for the delay in reviewing, this LGTM.

All good! Will need another round though (merge-conflict resolution in yarn.lock). Also bumped to latest 3.1.0.

@legobeat legobeat changed the title chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.0.4 chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 Jul 26, 2024
@legobeat legobeat merged commit 4fa46bf into MetaMask:main Jul 26, 2024
17 of 18 checks passed
Gudahtt added a commit that referenced this pull request Nov 1, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into v3.x
5d37d08 
* origin/main:
  feat: allow `npm:name@version` dependency redirections in manifest (#158)
  4.0.0 (#157)
  BREAKING: Bump `@metamask/auto-changelog` to `^4.0.0`, and bump related dependencies (#156)
  chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 (#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mcmire mcmire mcmire left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mcmire @cryptodev-2s