Add support for nested workspaces #84
Conversation
| @@ -155,7 +155,7 @@ export async function getStdoutFromCommand( | |||
| } | |||
|
|
|||
| /** | |||
| * Runs a Git command, splitting up the immediate output into lines. | |||
| * Run a command, splitting up the immediate output into lines. | |||
There was a problem hiding this comment.
This function can run any command, not just Git commands.
Mrtenz
force-pushed
the
mrtenz/support-nested-workspaces
branch
from
dd209cc
to
66ca2c0
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore @metamask/[email protected] This is our own. |
src/functional.test.ts
Outdated
| @@ -1,6 +1,8 @@ | |||
| import { withMonorepoProjectEnvironment } from '../tests/functional/helpers/with'; | |||
| import { buildChangelog } from '../tests/functional/helpers/utils'; | |||
|
|
|||
| jest.setTimeout(60_000); | |||
There was a problem hiding this comment.
60 seconds seems a bit high. Were there any tests in particular you found to take a long time, or just any of them?
There was a problem hiding this comment.
The tests were a bit flaky, but you're right that 60 seconds is not necessary. I'll change it to 10 seconds.
| @@ -1,6 +1,8 @@ | |||
| import { withMonorepoProjectEnvironment } from '../tests/functional/helpers/with'; | |||
| import { buildChangelog } from '../tests/functional/helpers/utils'; | |||
|
|
|||
| jest.setTimeout(10_000); | |||
|
|
|||
| describe('create-release-branch (functional)', () => { | |||
There was a problem hiding this comment.
It would be nice if we could write a functional test involving nested workspaces, but we can do that later.
This adds support for nested workspaces (workspaces in workspaces), by updating the logic to fetch workspaces. Rather than looking at the root
package.json, it now runsyarn workspaces list --no-privateto get a list of all workspaces.