Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: typescript@~4.8.4->~5.1.6 #93

Merged
merged 6 commits into from
Nov 14, 2023
Merged

devDeps: typescript@~4.8.4->~5.1.6 #93

merged 6 commits into from
Nov 14, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 7, 2023 •
edited
Loading

  • Bump TypeScript to latest 5.1.6
  • fix: Set default environment value to {EDITOR: undefined} instead of {}

@socket-security
Copy link

socket-security bot commented Sep 7, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typescript 4.8.4...5.1.6 None +0/-0 40.1 MB typescript-bot

@legobeat legobeat changed the title devDeps: typescript@~4.8.4->~4.9.5 devDeps: typescript@~4.8.4->~5.1.6 Sep 7, 2023
@legobeat legobeat marked this pull request as ready for review September 7, 2023 03:36
@legobeat legobeat requested a review from a team as a code owner September 7, 2023 03:36
@legobeat legobeat mentioned this pull request Sep 7, 2023
Draft
1 task
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 7, 2023
@legobeat legobeat force-pushed the devdeps-typescript branch 2 times, most recently from 745ff31 to 3376769 Compare September 29, 2023 01:56
@legobeat legobeat requested a review from a team October 13, 2023 07:33
mcmire
mcmire previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment.

tsconfig.build.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@legobeat legobeat removed the request for review from a team October 13, 2023 21:29
@legobeat legobeat requested review from mcmire and a team October 13, 2023 21:37
@legobeat legobeat requested review from a team October 18, 2023 05:55
@mcmire mcmire mentioned this pull request Nov 13, 2023
Merged
mcmire
mcmire approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit d3556b3 into MetaMask:main Nov 14, 2023
20 checks passed
@legobeat legobeat deleted the devdeps-typescript branch November 14, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire