Normalize rule config values #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Apr 20, 2021
| ).reduce((allRules, [ruleName, ruleValue]) => { | ||
| // Rules set to 'off' should never be enabled. | ||
| // Rules set to 0 (number) may sometimes be included. We don't attend to those. | ||
| // https://github.com/Prettier/eslint-config-Prettier/blob/abf3ba1/index.js#L7-L9 |
There was a problem hiding this comment.
Huh, interesting way of denoting optional settings.
Gudahtt
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule validation script wasn't taking into account that extended configs can use numerical (
0, 1, 2) or text (off, warn, error) notation for rule configs. This PR normalizes all rules in the snapshot to use text notation.I had to parameterize this behavior to make an exception for when we compute the required Prettier rules, because Prettier intentionally uses numerical notation for a subset of its rules to distinguish them from the rest.
Applying this change caught some redundantly configured rules.