Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-throw-literal config for TypeScript #201

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix no-throw-literal config for TypeScript #201

merged 1 commit into from
Aug 30, 2021

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 28, 2021 •
edited
Loading

Fixes the no-throw-literal rule configuration for TypeScript by enabling the appropriate rule in the TypeScript config, per documentation.

This is timely due to recent changes to TypeScript.

@rekmarks rekmarks requested a review from a team as a code owner August 28, 2021 19:29
Gudahtt
Gudahtt approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 278b245 into main Aug 30, 2021
@rekmarks rekmarks deleted the no-throw-literal branch August 30, 2021 16:31
@Gudahtt
Copy link
Member

Gudahtt commented Sep 22, 2021

Oops. This requires type information apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt