Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mocha ecmaVersion #218

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Update Mocha ecmaVersion #218

merged 1 commit into from
Apr 8, 2022

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 8, 2022

Updates the mocha config parserOptions.ecmaVersion to 2020. This allows us to use ES2020 features such as the spread operator in all its varied forms in our Mocha tests. We don't have to worry about compatibility for our end users because we're of course not shipping our tests anyway.

@rekmarks rekmarks requested a review from a team as a code owner April 8, 2022 21:56
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense (for as long as we are keeping our Mocha tests).

@rekmarks rekmarks merged commit 7d2a60d into main Apr 8, 2022
@rekmarks rekmarks deleted the update-mocha-ecmaVersion branch April 8, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants