Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable naming convention for properties that require quotes #293

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 25, 2023

Description

This pull request disables the naming conventions rule for properties that require quotes. Since we use quoted property names a lot in our codebases (for example, in permission names), it's easier to disable this rule for those globally, rather than disabling it for each property individually.

Changes

  1. Disable naming convention for properties that require quotes

@Mrtenz Mrtenz requested a review from a team as a code owner May 25, 2023 19:48
@Mrtenz Mrtenz force-pushed the mrtenz/quotes-properties-naming-convention branch from 0f3674e to 79066ac Compare May 26, 2023 09:28
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz force-pushed the mrtenz/quotes-properties-naming-convention branch from 79066ac to 35a8b18 Compare June 1, 2023 08:52
@Mrtenz Mrtenz merged commit 3031454 into main Jun 1, 2023
@Mrtenz Mrtenz deleted the mrtenz/quotes-properties-naming-convention branch June 1, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants