Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/peerDeps: replace eslint-plugin-node with eslint-plugin-n #297

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 7, 2023

eslint-plugin-node is unmaintained and suffers from several issues, which are addressed in the community for eslint-plugin-n.

@socket-security
Copy link

socket-security bot commented Jul 7, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-n 15.7.0 filesystem +6 833 kB weiran.zsd

🚮 Removed packages: [email protected]

@socket-security
Copy link

socket-security bot commented Jul 7, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

legobeat commented Jul 7, 2023

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

@legobeat legobeat force-pushed the node-peerDeps-eslint-plugin-node branch 2 times, most recently from 0a2e280 to 09e1ede Compare July 7, 2023 06:28
eslint-plugin-node is unmaintained and suffers from several issues,
which are addressed in the community for eslint-plugin-n.
@legobeat legobeat force-pushed the node-peerDeps-eslint-plugin-node branch from 09e1ede to b2cada0 Compare July 7, 2023 06:32
@legobeat legobeat marked this pull request as ready for review July 7, 2023 06:33
@legobeat legobeat requested a review from a team as a code owner July 7, 2023 06:33
@legobeat legobeat merged commit 80a1565 into MetaMask:main Jul 7, 2023
@legobeat legobeat deleted the node-peerDeps-eslint-plugin-node branch July 7, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants