Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Infura API v3 #32

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Use Infura API v3 #32

merged 1 commit into from
Sep 8, 2020

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Sep 4, 2020

This PR updates the project to use Infura's v3 API.

@whymarrh whymarrh mentioned this pull request Sep 4, 2020
@whymarrh whymarrh force-pushed the infura-v3 branch 3 times, most recently from 6b3b5d0 to 26907f4 Compare September 7, 2020 13:46
@whymarrh
Copy link
Contributor Author

whymarrh commented Sep 7, 2020

I've created #33 to note that rate limits aren't supported yet

@whymarrh
Copy link
Contributor Author

whymarrh commented Sep 7, 2020

I've created #34 to note that currently requests cannot be cancelled.

@whymarrh whymarrh marked this pull request as ready for review September 7, 2020 14:37
@whymarrh whymarrh requested a review from a team as a code owner September 7, 2020 14:37
@@ -77,7 +82,7 @@ async function performFetch (network, req, res, source) {
case 405:
throw rpcErrors.rpc.methodNotFound()

case 418:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this was here but it is no longer correct per the docs

rekmarks
rekmarks previously approved these changes Sep 8, 2020
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one optional suggestion.

test/index.js Show resolved Hide resolved
brad-decker
brad-decker previously approved these changes Sep 8, 2020
@whymarrh whymarrh merged commit 80560f3 into master Sep 8, 2020
@whymarrh whymarrh deleted the infura-v3 branch September 8, 2020 15:11
@whymarrh whymarrh mentioned this pull request Sep 9, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants