-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Drop support for Node.js v16,v21 #312
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/[email protected] |
Hey I noticed that we're adding support for versions In core (MetaMask/core#3611) and metamask-module-template (MetaMask/metamask-module-template#221), we only dropped v16 and didn't add support for v22. Have we looked into whether there are any breaking changes in v22 we should prepare for? It looks like v21-22 support was previously included in the |
I would expect that to be caught by tests..?
So, yes, we're not changing support contract ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to expand test coverage and drop support for v21. Thanks for the explanation @legobeat!
@types/node
to match minimum Node.js version^18.16
.nvmrc
tolts/*
to align with metamask-module-templateBlocking