Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Drop support for Node.js v16,v21 #312

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 13, 2024

  • Remove support for deprecated Node.js versions 16, 21
  • Bump devDependency @types/node to match minimum Node.js version ^18.16
  • Update Node versions in CI matrix
  • Set .nvmrc to lts/* to align with metamask-module-template

Blocking

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +1 2.04 MB types

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

@legobeat legobeat mentioned this pull request Jun 13, 2024
1 task
@legobeat legobeat marked this pull request as ready for review June 13, 2024 22:42
@legobeat legobeat requested a review from a team as a code owner June 13, 2024 22:42
@legobeat legobeat mentioned this pull request Jun 13, 2024
2 tasks
@legobeat legobeat changed the title BREAKING: drop support for Node.js v16; add support for ^20,>=22 BREAKING: Drop support for Node.js v16,v21 Jun 13, 2024
@MajorLift
Copy link
Contributor

Hey I noticed that we're adding support for versions >=22 here.

In core (MetaMask/core#3611) and metamask-module-template (MetaMask/metamask-module-template#221), we only dropped v16 and didn't add support for v22.

Have we looked into whether there are any breaking changes in v22 we should prepare for? It looks like v21-22 support was previously included in the engines.node package.json field, but not in the github actions.

@legobeat
Copy link
Contributor Author

legobeat commented Jul 3, 2024

Hey I noticed that we're adding support for versions >=22 here.

>=22 is not added but already included in existing/previous >=20.

Have we looked into whether there are any breaking changes in v22 we should prepare for?

I would expect that to be caught by tests..?

It looks like v21-22 support was previously included in the engines.node package.json field, but not in the github actions.

So, yes, we're not changing support contract (engines.node) wrt node v22 in this PR, but add test coverage for it here.

@legobeat legobeat requested a review from OGPoyraz July 3, 2024 21:24
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to expand test coverage and drop support for v21. Thanks for the explanation @legobeat!

@legobeat legobeat merged commit edd58dd into MetaMask:main Jul 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants