Add signTypedData version validation
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gudahtt
force-pushed
the
add-version-validation
branch
from
4c5f5a0
to
602f096
Compare
The `Version` parameter used by `signTypedData`-related functions has been converted to an enum, and all `version` parameters are now validated against this enum. The `TypedDataUtils` functions were written specifically for `V3` and `V4`, so `V1` is disallowed. If anyone was using these functions with `V1`, they were effectively using the `V3` versions.
Gudahtt
force-pushed
the
add-version-validation
branch
from
e84096d
to
287ffce
Compare
rekmarks
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Versionparameter used bysignTypedData-related functions has been converted to an enum, and allversionparameters are now validated against this enum.The
TypedDataUtilsfunctions were written specifically forV3andV4, soV1is disallowed. If anyone was using these functions withV1, they were effectively using theV3versions.