personal.sign parameter ordering seems wrong

[kenshyx]

From this this and this it should be personal.sign(message, account, pwd). After playing a while with the web3 injected by metamask it seems it's using (account, message).

[danfinlay]

Thank you so much for catching this. This is pretty bad.

Thinking of ways to fix this while breaking the least possible. I was thinking we could try to respect existing behavior while moving forwards, like:

personalSign(account, message) {
  let correctAccount, correctMessage
  if ( resemblesMessage(account) && resemblesAccount(message) {
    console.warn(`Sorry developers, you should switch the param order, ${LINK_TO_BLOG_POST}`)
    correctAccount = message
    correctMessage = account
  }
  return oldPersonalSign(correctMessage, correctAccount)
}

Thoughts?

[kumavis]

That sounds pretty good Dan, what's the worst that could happen here? Accidently swapping the values if the message looks like an address?

[kumavis]

I guess we could load the addresses and see if there's a match to tell the difference