[Bug] Balance text not visible when signing with Ledger (legacy) account #11522
Assignees
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
QA Passed
A successful QA run through has been done
release-7.34.0
team-hardware-wallets
type-bug
Something isn't working
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
vivek-consensys
added
QA Passed
|
Tested on iOS and Android, balance text visible using Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf8a879f-3763-4f7c-9291-ff84576d0c39 |
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 16, 2024
… push balance information outside the border of screen. (#11550) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** When import a ledger legacy account in Metamask, and user go to click `Personal Sign` . sometimes the balance is out of border of the personal sign screen, please see the attached screen image for detail. This PR fix the layout issue to put the account label below the account name so that in smaller screen, account balance will not be put out of box. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #11522 ## **Manual testing steps** 1. Install MM 2. Recover from SRP 3. Add Ledger hardware wallet and connect Ledger 2x account 4. Launch MM test dapp 5. Connect Ledger legacy account on test dapp 6. Sign Permit with account ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  <!-- [screenshots/recordings] --> ### **After**   <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OS: iPhone 13
Version: TestFlight v7.32.0 (1439)
Expected: All test within alignment and visible
Actual:
The text was updated successfully, but these errors were encountered: