You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When import a ledger legacy account in Metamask, and user go to click Personal Sign . sometimes the balance is out of border of the personal sign screen, please see the attached screen image for detail.
This PR fix the layout issue to put the account label below the account name so that in smaller screen, account balance will not be put out of box.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
LGTM! We can go ahead with these changes as they leverage an existing pattern. These designs will soon be replaced with the new confirmation designs. You can find the relevant Figma here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dawnseeker8
added
needs-dev-review
github-actions
bot
removed
the
needs-dev-review
Description
When import a ledger legacy account in Metamask, and user go to click
Personal Sign. sometimes the balance is out of border of the personal sign screen, please see the attached screen image for detail.This PR fix the layout issue to put the account label below the account name so that in smaller screen, account balance will not be put out of box.
Related issues
Fixes: #11522
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist