New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create re-designed personal sign page #11529

Closed

jpuri opened this issue Oct 1, 2024 · 1 comment · Fixed by #11602

Assignees

Labels

INVALID-ISSUE-TEMPLATE release-7.34.0

Contributor

jpuri commented Oct 1, 2024 •

edited

Loading

Create re-designed personal sign page
figma: https://www.figma.com/design/CeAIcptzeaI5ciTpYBaiqr/Confirmations-DS?node-id=4314-18644&node-type=instance&t=kkcRsIctW0xWJDIP-0

metamaskbot added the INVALID-ISSUE-TEMPLATE label

jpuri changed the title ~~Add very basic personal sign page~~ Create re-designed personal sign page

This comment was marked as spam.

Sign in to view

jpuri self-assigned this

jpuri mentioned this issue

feat: adding a basic personal sign page re-designed #11602

Merged

7 tasks

github-merge-queue bot pushed a commit that referenced this issue


          feat: adding a basic personal sign page re-designed (#11602)

22b0012

## **Description**

Re-designed personal sign page

## **Related issues**

Fixes: #11529

## **Manual testing steps**

1. Enable re-designed confirmations locally
2. To to test dapp
3. Submit personal sign request and check page that appears

## **Screenshots/Recordings**
<img width="407" alt="Screenshot 2024-10-03 at 8 05 44 PM"
src="https://github.com/user-attachments/assets/0bbf0562-26e1-47ce-a2aa-0a4abd81119c">

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

jpuri closed this as completed in #11602

gauthierpetetin added the release-7.34.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment