Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Segment patch by plugin #11350

Merged
merged 12 commits into from
Oct 2, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Sep 20, 2024

Description

Replace the Segment SDK patch that was updating events for anonymous user id by a plugin that does the same

Important

This PR doesn't change the behaviour of the metrics system.
It only allows to get rid of the patch.

Related issues

Fixes #11219
May also fix #11065

Manual testing steps

  1. navigate the app
  2. check events landing on Segment, then Mixpanel have the proper user ID
  • if anonymous: the 0x0000...0000 id
  • if not anonymous the random UUIDv4

Screenshots/Recordings

Before

Same as after, no functional change

After

The non anonymous part of the event (no properties, but userId)
image

The anonymous part of the event (properties, but userId replaced by anonymous id)
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart marked this pull request as ready for review September 20, 2024 21:31
@NicolasMassart NicolasMassart requested review from a team as code owners September 20, 2024 21:31
@NicolasMassart NicolasMassart added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
@NicolasMassart NicolasMassart changed the title fix: replace Segment patch by plugin chore: replace Segment patch by plugin Sep 20, 2024
@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d808284
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/22834ccc-c05e-47dc-b4c5-bf018f8c11ba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 2, 2024
@NicolasMassart NicolasMassart removed this pull request from the merge queue due to a manual request Oct 2, 2024
@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d2ddcdc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af476cc5-af47-4744-b090-863884b36509

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 2, 2024

@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 2, 2024
@NicolasMassart NicolasMassart removed this pull request from the merge queue due to a manual request Oct 2, 2024
@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit d855104 Oct 2, 2024
42 of 43 checks passed
@NicolasMassart NicolasMassart deleted the 11219_replace_segment_patch_by_plugin branch October 2, 2024 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
3 participants