Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add UX CodeOwners responsibilities #11491

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

vinnyhoward
Copy link
Contributor

Description

Adds preliminary CODEOWNERS for Wallet UX. We'll see how accurate this is and expand accordingly.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Sep 27, 2024
@vinnyhoward vinnyhoward requested a review from a team as a code owner September 27, 2024 19:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing
darkwing previously approved these changes Sep 27, 2024
Copy link

sonarcloud bot commented Sep 27, 2024

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now. We may need to refine these codepaths a bit down the line so that we don't end up having to code own everything on mobile

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 201a806 Oct 2, 2024
36 checks passed
@vinnyhoward vinnyhoward deleted the chore-mobile-ux-codeowners branch October 2, 2024 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants