Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android firebase docs template #11512

Merged
merged 9 commits into from
Oct 1, 2024
Merged

fix: android firebase docs template #11512

merged 9 commits into from
Oct 1, 2024
+16 −6

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR implements a fix for the build issue while building for Android using the google service template.

Related issues

Fixes: This

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Sep 30, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner September 30, 2024 22:19
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 30, 2024
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-snaps-platform Snaps Platform team labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bd85ab7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac433f22-71c7-4528-907b-f22108bf9d69

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

ccharly
ccharly reviewed Oct 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Jonathansoufer and others added 4 commits October 1, 2024 10:59
@Jonathansoufer @ccharly
Update README.md
442c525 
Co-authored-by: Charly Chevalier <[email protected]>
@Jonathansoufer @ccharly
Update README.md
95b01df 
Co-authored-by: Charly Chevalier <[email protected]>
@Jonathansoufer @ccharly
Update README.md
1bfdd2c 
Co-authored-by: Charly Chevalier <[email protected]>
@Jonathansoufer @ccharly
Update README.md
a359115 
Co-authored-by: Charly Chevalier <[email protected]>
@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ce75ddc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf7495e5-c91a-4bde-a7c4-44cc9384973e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit d49bb50 Oct 1, 2024
41 of 42 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/android-firebase-docs-template branch October 1, 2024 15:01
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@ccharly ccharly ccharly approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonathansoufer @ccharly @gantunesr @gauthierpetetin