chore(js-ts): Convert app/components/UI/GenericButton/index.ios.js to TypeScript #11523
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
devin-ai-integration
bot
added
team-mobile-platform
needs-dev-review
|
|
kylanhurt
deleted the
devin/convert-ts-app-components-UI-GenericButton-index-ios.js-9184
branch
github-actions
bot
removed
the
needs-dev-review
gauthierpetetin
added
the
release-7.33.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the
app/components/UI/GenericButton/index.ios.jsfile to TypeScript. The conversion involves updating the file extension to.tsx, defining TypeScript interfaces for props, and removingpropTypes.Motivation
The conversion to TypeScript is part of an ongoing effort to improve type safety and maintainability across the codebase.
Context
The
GenericButtoncomponent is deprecated in favor of the newButtoncomponent from the component-library. This conversion ensures that the deprecated component is type-safe until it is fully replaced.Related Issues
Manual Testing Steps
GenericButtoncomponent renders correctly in the app.children,style,onPress) function as expected.Screenshots/Recordings
N/A
Additional Information
If you have any feedback, you can leave comments in the PR and I'll address them in the app!