Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix duplicated network select #11524

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 1, 2024

Description

his PR introduces a fix for handling multiple networks with different RPC URLs in the NetworkSelector component, along with comprehensive unit tests to ensure the component's functionality. The tests verify that only one network can be selected at a time, even when the networks have the same chain ID but different RPC URLs.

Related issues

Fixes: #11509

Manual testing steps

  1. add tow different polygon network with two different rpc
  2. switch between them

Screenshots/Recordings

Before

before.mov

After

after-2.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added regression-RC-7.32.0 Regression bug that was found in release candidate (RC) for release 7.32.0 Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1eb05d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/157b0ac1-0128-4461-b6ae-8d50bc68e4ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb marked this pull request as ready for review October 1, 2024 12:39
@salimtb salimtb requested a review from a team as a code owner October 1, 2024 12:39
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1ec9679
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cc9eed9c-4b12-498e-87f3-92de627c5a5b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 2, 2024

@salimtb salimtb added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit dc133a5 Oct 2, 2024
43 checks passed
@salimtb salimtb deleted the salim/fix-duplicated-network-select branch October 2, 2024 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression-RC-7.32.0 Regression bug that was found in release candidate (RC) for release 7.32.0 release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error thrown for duplicated network
3 participants