test:stablize swaps e2e #11559
test:stablize swaps e2e #11559
Conversation
| @@ -34,12 +33,27 @@ class SwapView { | |||
| return title; | |||
| } | |||
|
|
|||
| async scrollToBottomOfView(tokenName) { | |||
There was a problem hiding this comment.
One source of flakiness: The price warning pushes the swaps slider out of the detox view port. This method just scrolls to the bottom of the swaps confirmations view
| await Gestures.swipe(token, 'up', 'fast', 0.8); | ||
| } | ||
| // Function to check if the button is enabled | ||
| async isButtonEnabled(element) { |
There was a problem hiding this comment.
Second source of flakiness: In some instances, while on the swaps confirmation view, the app is fetching quotes. Because of this, detox sometimes waits until the swipe-to-swap slider is enabled. In some instances, detox times out because the slider is not enabled. This method checks to see if the slider element is enabled.
| const delay = 500; // Delay in milliseconds | ||
|
|
||
| // Wait until the button is enabled before performing swipe actions | ||
| while (!(await this.isButtonEnabled(swapsSliderElement))) { |
There was a problem hiding this comment.
this loops until the slider becomes enabled. Once enabled the test proceeds to the next step
| @@ -14,6 +14,7 @@ | |||
| ".*phishing-detection.cx.metamask.io/.*", | |||
| ".*eth.llamarpc.com/.*", | |||
| ".*token-api.metaswap.codefi.network/.*", | |||
| ".*gas.api.cx.metamask.io/networks/*" | |||
| ".*gas.api.cx.metamask.io/networks/*", | |||
| ".*rpc.vnet.tenderly.co/.*" | |||
There was a problem hiding this comment.
blacklist tenderly endpoints to prevent the app from waiting for requests to complete before proceeding.
|
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist