Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix invalid browser url crash #11581

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 2, 2024

Description

This PR fixes the crash in 7.32.0 for invalid URL in browser. The global URL didn't catch invalid urls gracefully, so we are using the lib url-parser

Related issues

Fixes: #11479

Manual testing steps

  1. Go to browser
  2. Enter httttps://app.uniswap.org
  3. Website shows invalid url scheme
  4. App doesn't crash

Screenshots/Recordings

Before

After

invalid-url-fix.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner October 2, 2024 19:27
@Cal-L Cal-L added team-mobile-platform needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ae13b3b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcbfcc8a-70be-48a8-a4ca-77f41cf9ba40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 2, 2024

@Cal-L Cal-L enabled auto-merge October 2, 2024 19:41
@Cal-L Cal-L disabled auto-merge October 2, 2024 19:41
Copy link
Contributor

@frankvonhoven frankvonhoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvonhoven frankvonhoven added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit e80a1e8 Oct 2, 2024
61 checks passed
@frankvonhoven frankvonhoven deleted the fix/11479-invalid-browser-url branch October 2, 2024 20:05
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
2 participants