Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token details view undefined value #11631

Merged
merged 4 commits into from
Oct 4, 2024
Merged

fix: token details view undefined value #11631

merged 4 commits into from
Oct 4, 2024

Conversation

gambinish
Copy link
Contributor

Description

Fixes token details view when tokenExchangeRates have not yet resolved, or are simply undefined.

Related issues

Fixes: #11539

Manual testing steps

  1. Go to TokenDetails
  2. Hardcode tokenExchangeRates to undefined
  3. App should not crash. Token details will be empty. Error was when pressing native gas token, but also check others.

Screenshots/Recordings

Bug:

Screenshot 2024-10-04 at 10 39 05 AM

Fix:

Screenshot 2024-10-04 at 10 40 31 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6005a74
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09b07c29-19da-4a84-bea9-dc57f0b24e7d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish marked this pull request as ready for review October 4, 2024 17:48
@gambinish gambinish requested a review from a team as a code owner October 4, 2024 17:48
Copy link

sonarcloud bot commented Oct 4, 2024

@Cal-L Cal-L added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit e02ccb4 Oct 4, 2024
37 checks passed
@Cal-L Cal-L deleted the hotfix/issue-11539 branch October 4, 2024 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@NicolasMassart NicolasMassart changed the title fix: hotfix/issue-11539 fix: token details view undefined value Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Sentry] TypeError: Cannot convert undefined value to object
5 participants