Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1957 crash screen redesign #12015

Merged
merged 28 commits into from
Nov 10, 2024
Merged

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Oct 24, 2024

Description

Refactors ErrorBoundary to match updated designs in Figma

Related issues

Fixes: #1957

Manual testing steps

  1. Go WalletView
  2. Add:
    useEffect(() => {
      throw new Error('Test Error');
    }, []);
    
  3. Restart the app
  4. Dismiss the Red Screen
  5. See the new Error Screen

TESTING THE BUILD:

  1. Create a QA build in Bitrise
  2. force an error
  3. report the error
  4. check Sentry
  5. Should see user feedback in the Sentry report
  6. Example:
    image

Screenshots/Recordings

Before

image

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-07.at.13.11.44.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

sentry-io bot commented Oct 24, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/components/Views/ErrorBoundary/index.js

Function Unhandled Issue
createStyles TypeError: a.StyleSheet.create is not a function. (In 'a.StyleSheet.create({container:{flex:1,backgroundColo... ...
Event Count: 1 Affected Users: 2
createStyles TypeError: undefined is not an object (evaluating 'e.background') createStyles(app/components/Views/Err...
Event Count: 1 Affected Users: 2
createStyles TypeError: undefined is not an object (evaluating '_r(d[13]).fontStyles.bold') createStyles(app/compone...
Event Count: 1 Affected Users: 1
createStyles TypeError: undefined is not an object (evaluating 'e.text.default') createStyles(app/components/Views/E...
Event Count: 1 Affected Users: 2

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 24, 2024
@frankvonhoven frankvonhoven marked this pull request as ready for review October 25, 2024 16:43
@frankvonhoven frankvonhoven requested a review from a team as a code owner October 25, 2024 16:43
@frankvonhoven frankvonhoven requested a review from a team as a code owner October 28, 2024 19:31
@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e8daf14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/365731c4-f570-49b6-a42e-a5b11ef114f9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@hesterbruikman hesterbruikman added the design-review Any feature that needs feedback from the design team label Nov 5, 2024
@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1d5aa7f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/530a1570-f651-4fa0-a4d6-ddae479c2b32

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool, nice job @frankvonhoven @yanrong-chen
LGTM✅

@frankvonhoven frankvonhoven added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@frankvonhoven frankvonhoven added this pull request to the merge queue Nov 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Refactors ErrorBoundary to match [updated designs in
Figma](https://www.figma.com/design/DM5G1pyp74sMJwyKbw1KiR/Error-message-and-bug-report?node-id=1-5473&node-type=section&t=98CWfEC4JrKwpNCE-0)

## **Related issues**

Fixes: [#1957](MetaMask/mobile-planning#1957)

## **Manual testing steps**

1. Go WalletView
2. Add:
    ```
    useEffect(() => {
      throw new Error('Test Error');
    }, []);
    ```
3. Restart the app
4. Dismiss the Red Screen
5. See the new Error Screen

## TESTING THE BUILD:
1. Create a QA build in Bitrise
2. force an error
3. report the error
4. check
[Sentry](https://metamask.sentry.io/feedback/?feedbackSlug=test-metamask-mobile%3A6031686409&mailbox=ignored&project=2651591&referrer=feedback_list_page&statsPeriod=30d)
5. Should see user feedback in the Sentry report
6. Example:

![image](https://github.com/user-attachments/assets/c1737758-5739-48f9-96d1-798e523f5be3)


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
<img width="753" alt="image"
src="https://github.com/user-attachments/assets/136542c2-1578-4e87-9922-154f21a70c4e">


### **After**

<!-- [screenshots/recordings] -->



https://github.com/user-attachments/assets/7dbe5e04-0152-41bc-984a-37cba98c4eeb


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Daniel Cross <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@frankvonhoven frankvonhoven added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@frankvonhoven frankvonhoven added this pull request to the merge queue Nov 10, 2024
Merged via the queue into main with commit 12c3e59 Nov 10, 2024
36 of 37 checks passed
@frankvonhoven frankvonhoven deleted the feat/1957-crash-screen-redesign branch November 10, 2024 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 10, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design-review Any feature that needs feedback from the design team release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants