-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1957 crash screen redesign #12015
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: app/components/Views/ErrorBoundary/index.js
Did you find this useful? React with a 👍 or 👎 |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: e8daf14 Note
|
…/metamask-mobile into feat/1957-crash-screen-redesign
…/metamask-mobile into feat/1957-crash-screen-redesign
Bitrise❌❌❌ Commit hash: 1d5aa7f Note
Tip
|
…/metamask-mobile into feat/1957-crash-screen-redesign
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool, nice job @frankvonhoven @yanrong-chen
LGTM✅
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Refactors ErrorBoundary to match [updated designs in Figma](https://www.figma.com/design/DM5G1pyp74sMJwyKbw1KiR/Error-message-and-bug-report?node-id=1-5473&node-type=section&t=98CWfEC4JrKwpNCE-0) ## **Related issues** Fixes: [#1957](MetaMask/mobile-planning#1957) ## **Manual testing steps** 1. Go WalletView 2. Add: ``` useEffect(() => { throw new Error('Test Error'); }, []); ``` 3. Restart the app 4. Dismiss the Red Screen 5. See the new Error Screen ## TESTING THE BUILD: 1. Create a QA build in Bitrise 2. force an error 3. report the error 4. check [Sentry](https://metamask.sentry.io/feedback/?feedbackSlug=test-metamask-mobile%3A6031686409&mailbox=ignored&project=2651591&referrer=feedback_list_page&statsPeriod=30d) 5. Should see user feedback in the Sentry report 6. Example: ![image](https://github.com/user-attachments/assets/c1737758-5739-48f9-96d1-798e523f5be3) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="753" alt="image" src="https://github.com/user-attachments/assets/136542c2-1578-4e87-9922-154f21a70c4e"> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/7dbe5e04-0152-41bc-984a-37cba98c4eeb ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Daniel Cross <[email protected]>
Description
Refactors ErrorBoundary to match updated designs in Figma
Related issues
Fixes: #1957
Manual testing steps
TESTING THE BUILD:
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-07.at.13.11.44.mp4
Pre-merge author checklist
Pre-merge reviewer checklist