Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade assets controllers to v44 #12344

Draft
wants to merge 12 commits into
base: brian/assets-controllers-43
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 20, 2024

Description

Upgrades the assets controllers to v44. In this version, the token balances controller now stores erc20 balances across all chains and accounts, instead of just the current chain and account like before. This allows polling erc20 balances across chains.

Related issues

Depends on: #12340

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

  1. Onboard
  2. Verify erc20 tokens have correct balances
  3. Switch chains
  4. Verify the erc20 tokens on the new chain have correct balances
  5. Send a TX that changes an erc20 balance
  6. Verify it gets updated after tx completes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title Brian/asset controller 44 feat: upgrade assets controllers to v44 Nov 20, 2024
Copy link

socket-security bot commented Nov 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +3 3.08 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants