Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] SES lockdown() - LavaMoat Compatibility #3794

Closed
wants to merge 3 commits into from
Closed

[WIP] SES lockdown() - LavaMoat Compatibility #3794

wants to merge 3 commits into from

Conversation

bentobox19
Copy link
Contributor

@bentobox19 bentobox19 commented Feb 22, 2022 •
edited
Loading

Compatibility Documentation: LavaMoat/docs#1

  • Add ses dependency
    • Tell babel to ignore its transformation
    • Tell metro to accept a .cjs file as dependency entry point
  • Add SES lockdown() call
  • Modifications required for the application to work
    • Disable default integration in Sentry
    • Add patches
      • React Native to disable Promise polyfill
      • Metro React Native Babel Preset to disable two plugins
      • ethjs dependencies leveraging babel runtime
      • web3 dependency assigning a frozen intrinsic.

Extensive QA required ❗

@bentobox19 bentobox19 self-assigned this Feb 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2022 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bentobox19
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bentobox19 bentobox19 mentioned this pull request Feb 25, 2022
Closed
11 tasks
@bentobox19
Copy link
Contributor Author

bentobox19 commented Mar 19, 2022 •
edited
Loading

Force pushed a shorter and cleaner version of the changes needed to run lockdown().

@bentobox19 bentobox19 force-pushed the feature/ses-lockdown branch 2 times, most recently from eb673a0 to af66e5c Compare June 8, 2022 02:27
@bentobox19
Copy link
Contributor Author

New force push

@bentobox19
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gantunesr
Copy link
Member

Closed per sync with @bentobox19

@gantunesr gantunesr closed this Dec 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
@legobeat
Copy link
Contributor

legobeat commented May 3, 2023

@bentobox19 @gantunesr Would you be able to share some context on this and the decision to close it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bentobox19 bentobox19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentobox19 @gantunesr @legobeat