Upgrade/react native/0.71.6 (v8 Android-only) #6119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8-android-jit variant includes both JIT & Intl support
jpcloureiro
force-pushed
the
upgrade/react-native/0.71.6
branch
from
fd9ea28
to
8b0f737
Compare
And fix error: method does not override or implement a method from a supertype (@OverRide outside mReactNativeHost) Otherwise Android runs JSC failing at runtime with 1n or BigInt(1) as expected: No identifiers allowed directly after numeric literal x2 no stack x2 (emu stacktrace, not Metro)
patch-package react-native-v8 creates 271 diffs after no changes, so this excludes those diffs
Fix pod install:
[!] CocoaPods could not find compatible versions for pod "RNV8":
In Podfile:
RNV8 (from `../node_modules/react-native-v8`)
Specs satisfying the `RNV8 (from `../node_modules/react-native-v8`)` dependency were found, but they required a higher minimum deployment target.
Better solution would be a PR like:
Kudo/react-native-v8#172
- Fix indentation - Unify tabs to spaces - Remove trailing spaces
Results as expected
This reverts commit 5607569.
This reverts commit 9fa5b25.
leotm
changed the title
76 tasks
|
Closing in favour of |
|
nb: Android V8 slow UI issue resolved now in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Draft PR to preview diff compared to
mainon.nvmrcbumped to ensure Node 16react-native-svgMetro config@ethereumjs/utilmethods and BigIntScreenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist