Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENS name displayed on confirm send page #6350

Merged
merged 7 commits into from
May 18, 2023
Merged

Fix ENS name displayed on confirm send page #6350

merged 7 commits into from
May 18, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 8, 2023

Fixes: #6330

Show ENS name of to address in confirmation page.

QA Steps:

  • start a send transaction on mainnet
  • enter an ens address, go to next page
  • enter amount, go to confirm page
  • ENS name of to address should be visible

@jpuri jpuri requested a review from a team as a code owner May 8, 2023 08:56
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Add unit test coverage Fix ENS name displayed on confirm send page May 8, 2023
@jpuri jpuri requested a review from segun May 10, 2023 00:14
blackdevelopa
blackdevelopa previously approved these changes May 10, 2023
@jpuri jpuri added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 12, 2023
@Cal-L Cal-L dismissed stale reviews from blackdevelopa and digiwand via 9057b2f May 15, 2023 18:13
@seaona
Copy link
Contributor

seaona commented May 18, 2023

I can see the ENS name on the confirmations page now. Looks good to be merged 💯 @jpuri

image

@seaona seaona added QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 18, 2023
@jpuri jpuri merged commit fbbd7d5 into main May 18, 2023
@jpuri jpuri deleted the ens_fix branch May 18, 2023 13:28
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 unit test coverage confirmed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ENS domain not displayed on the Confirmation screen
4 participants