Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add tags and simplify feature description #6353

Merged
merged 2 commits into from
May 9, 2023
Merged

[FIX] Add tags and simplify feature description #6353

merged 2 commits into from
May 9, 2023

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented May 9, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Added tags to feature files to make it easier to run smaller sets of test based on area.
  • Simplified feature description to make it easier to understand feature and make it look better on reports.

Screenshots/Recordings

Issue

Progresses #https://github.com/MetaMask/mobile-planning/issues/949

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@chrisleewilcox chrisleewilcox requested a review from a team as a code owner May 9, 2023 02:46
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox changed the title add tags and simplify feature description [FIX] Add tags and simplify feature description May 9, 2023
Andepande
Andepande approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NicolasMassart
NicolasMassart approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisleewilcox chrisleewilcox merged commit cd052af into release/6.6.0 May 9, 2023
@chrisleewilcox chrisleewilcox deleted the appium/add-tags-simplify-feature-desc branch May 9, 2023 13:08
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@Andepande Andepande Andepande approved these changes

Assignees
No one assigned
Labels
Appium E2E team-mobile-platform tests Test related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisleewilcox @NicolasMassart @Andepande @gauthierpetetin