[FIX] Send ETH displays Collectible as predefault value in the Amount screen and undefined balance #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
blackdevelopa
added
needs-dev-review
blackdevelopa
added
regression-RC
segun
approved these changes
May 22, 2023
|
Hey @blackdevelopa : possible to unit test cover this ? |
|
From QA looks good @blackdevelopa |
|
@blackdevelopa @seaona please merge PR once it is QA Passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever we install MetaMask for the first time (update into the release 6.5) when I click to Send, I can see how the selected token is Collectible instead of ETH. Also we see how there is an undefined value in the Balance.
Screenshots/Recordings
Before
https://user-images.githubusercontent.com/54408225/236208836-d75ecf6c-7837-4d0c-a952-69b2114ad03d.mp4
After
http://recordit.co/z3MLmaqYLe
Issue
Fixes: #6331, #6272
Checklist