Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(bitrise): fix pod install step #6543

Merged
merged 7 commits into from
Jun 6, 2023
Merged

ci(bitrise): fix pod install step #6543

merged 7 commits into from
Jun 6, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jun 6, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes the pod install failure seen on iOS builds. The caching step was causing install failures and a minor ruby bump was applied.

Screenshots/Recordings

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 6, 2023
@sethkfman sethkfman marked this pull request as ready for review June 6, 2023 18:39
@sethkfman sethkfman requested a review from a team as a code owner June 6, 2023 18:39
tommasini
tommasini approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Curiosity, are we removing the cocoapods cache indefinitely or just now to grab these changes and not apply anything old?
Will removing it increases the build time?

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 6, 2023
@sethkfman
Copy link
Contributor Author

@tommasini The plan is to remove it until we have RN upgrade in and Bitrise has stabilized

@sethkfman sethkfman merged commit a3853ef into main Jun 6, 2023
@sethkfman sethkfman deleted the fix/pod-init branch June 6, 2023 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethkfman @tommasini