Fix incomplete PPOMController{,Messenger} API, bump @metamask/base-controller to ^6.0.2
#769
MajorLiftmain.yml
on: pull_request
Build, lint, and test
/
Prepare
2m 27s
Check workflows
8s
Matrix: Build, lint, and test / Build
Matrix: Build, lint, and test / Lint
Matrix: Build, lint, and test / Test
Publish release
/
...
/
Publish docs to GitHub Pages
publish-release
/
...
/
Publish docs to GitHub Pages
Annotations
12 errors and 7 warnings
|
Build, lint, and test / Lint (20.x):
src/ppom-controller.ts#L1
Replace `·ControllerGetStateAction,·ControllerStateChangeEvent,·RestrictedControllerMessenger·` with `⏎··ControllerGetStateAction,⏎··ControllerStateChangeEvent,⏎··RestrictedControllerMessenger,⏎`
|
|
Build, lint, and test / Lint (20.x):
src/ppom-controller.ts#L130
Replace `typeof·controllerName,·PPOMState` with `⏎··typeof·controllerName,⏎··PPOMState⏎`
|
|
Build, lint, and test / Lint (20.x):
src/ppom-controller.ts#L134
Replace `typeof·controllerName,·PPOMState` with `⏎··typeof·controllerName,⏎··PPOMState⏎`
|
|
Build, lint, and test / Lint (20.x):
test/test-utils.ts#L13
Import "PPOMControllerEvents" is only used as types
|
|
Build, lint, and test / Lint (20.x)
Process completed with exit code 1.
|
|
Build, lint, and test / Lint (18.x)
The job was canceled because "_20_x" failed.
|
|
Build, lint, and test / Lint (18.x):
src/ppom-controller.ts#L1
Replace `·ControllerGetStateAction,·ControllerStateChangeEvent,·RestrictedControllerMessenger·` with `⏎··ControllerGetStateAction,⏎··ControllerStateChangeEvent,⏎··RestrictedControllerMessenger,⏎`
|
|
Build, lint, and test / Lint (18.x):
src/ppom-controller.ts#L130
Replace `typeof·controllerName,·PPOMState` with `⏎··typeof·controllerName,⏎··PPOMState⏎`
|
|
Build, lint, and test / Lint (18.x):
src/ppom-controller.ts#L134
Replace `typeof·controllerName,·PPOMState` with `⏎··typeof·controllerName,⏎··PPOMState⏎`
|
|
Build, lint, and test / Lint (18.x):
test/test-utils.ts#L13
Import "PPOMControllerEvents" is only used as types
|
|
Build, lint, and test / Lint (18.x)
Process completed with exit code 1.
|
|
All jobs pass
Process completed with exit code 1.
|
|
Check workflows
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Prepare
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Lint (20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Build (18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Test (20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Build (20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build, lint, and test / Test (18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|