Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NetworkController event subscription #192

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix NetworkController event subscription #192

merged 1 commit into from
Jul 24, 2024

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Jul 24, 2024 •
edited
Loading

Subscribe to the networkDidChange event of NetworkController instead of the stateChange event.

Fixes #191

@kanthesha kanthesha marked this pull request as ready for review July 24, 2024 10:47
@kanthesha kanthesha requested a review from a team as a code owner July 24, 2024 10:47
cryptodev-2s
cryptodev-2s approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kanthesha kanthesha merged commit 2083f51 into main Jul 24, 2024
16 checks passed
@kanthesha kanthesha deleted the fix/network-controller-event-subscription branch July 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscribe to networkDidChange instead of stateChange event from NetworkController
2 participants
@kanthesha @cryptodev-2s