Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @metamask/-namespaced dependencies to latest, recategorize @metamask/network-controller to peer dependency #215

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 1, 2024

Changelog

### Changed

- **BREAKING:** Bump `@metamask/base-controller` from `^6.0.2` to `^7.0.1`
- **BREAKING:** Bump `@metamask/controller-utils` from `^8.0.1` to `^11.3.0`
- **BREAKING:** Bump `@metamask/utils` from `^8.3.0` to `^9.2.1`
- Bump `@metamask/rpc-errors` from `^6.3.1` to `^6.4.0`

### Fixed

- **BREAKING:** Add `@metamask/network-controller` as dev dependency (`^21.0.1`) and peer dependency (`^21.0.0`)
  - Remove `@metamask/network-controller` as dependency.
  - This peer dependency relationship was already relied upon since `0.16.0`, when `PPOMController` started communicating with `NetworkController` via messenger, but was not reflected in the package manifest until now.

References

@MajorLift MajorLift added dependencies Pull requests that update a dependency file team-wallet-framework labels Oct 1, 2024
@MajorLift MajorLift self-assigned this Oct 1, 2024
Copy link

socket-security bot commented Oct 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 344 kB metamaskbot
npm/@metamask/[email protected] network 0 259 kB danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/[email protected] None 0 64.5 kB lgbot
npm/@metamask/[email protected] network 0 173 kB metamaskbot
npm/@metamask/[email protected] None 0 56.6 kB metamaskbot
npm/@metamask/[email protected] None 0 321 kB lgbot
npm/@metamask/[email protected] None 0 177 kB metamaskbot
npm/@metamask/[email protected] environment 0 638 kB metamaskbot
npm/@metamask/[email protected] None 0 292 kB lgbot
npm/@metamask/[email protected] None 0 165 kB metamaskbot
npm/@metamask/[email protected] None 0 695 kB metamaskbot
npm/@spruceid/[email protected] None 0 36.3 kB sbihel
npm/[email protected] None 0 646 kB acemarke
npm/[email protected] None 0 17.2 kB odysseas

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@spruceid/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Oct 1, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@spruceid/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@MajorLift MajorLift marked this pull request as ready for review October 1, 2024 14:17
@MajorLift MajorLift requested a review from a team as a code owner October 1, 2024 14:17
@MajorLift
Copy link
Contributor Author

@SocketSecurity ignore npm/@spruceid/[email protected]

New author has several years' track record as npm publisher.

@MajorLift MajorLift requested a review from a team October 1, 2024 15:31
@MajorLift MajorLift changed the title Bump @metamask/-namespaced dependencies to latest, convert @metamask/network-controller to peer dependency Bump @metamask/-namespaced dependencies to latest, recategorize @metamask/network-controller to peer dependency Oct 1, 2024
@MajorLift MajorLift merged commit 0e9a282 into main Oct 2, 2024
16 checks passed
@MajorLift MajorLift deleted the jongsun/chore/bump/241001-all branch October 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump all dependencies to their latest major versions
2 participants