Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for ethereum mainnet #48

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Fix the check for ethereum mainnet #48

merged 6 commits into from
Sep 6, 2023

Conversation

jpuri
Copy link
Collaborator

@jpuri jpuri commented Sep 6, 2023

correct the check for ethereum mainnet

@jpuri jpuri requested a review from a team as a code owner September 6, 2023 05:45
@legobeat
Copy link

legobeat commented Sep 6, 2023

What is the purpose of this change and how does it relate to the changed test?

src/ppom-controller.ts Outdated Show resolved Hide resolved
@jpuri jpuri dismissed legobeat’s stale review September 6, 2023 10:23

Change implemented

@jpuri jpuri merged commit 1ed7e90 into main Sep 6, 2023
15 checks passed
@jpuri jpuri deleted the eth_mainnet_fix branch September 6, 2023 10:23
@legobeat legobeat mentioned this pull request Sep 6, 2023
@jpuri
Copy link
Collaborator Author

jpuri commented Sep 11, 2023

What is the purpose of this change and how does it relate to the changed test?

The purpose of this change is:

  1. To fix the check that user has made the transaction on mainnet which is here
  2. To add hex prefix to network chainId which is required for mobile platform change here

The test remove should refresh data if network is changed and data is not available for new network is no more relevant as validator now works for only mainnet, but some control flow needed to be test covered that I added this new test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants